-
Notifications
You must be signed in to change notification settings - Fork 134
sonic-host-services changes for gNOI Cold Reboot #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rkavitha-hcl
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
rkavitha-hcl:gnoi_cr_host_services
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+411
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@hdwhdw @vvolam @qiluo-msft Pls review |
efb38de to
0a7c80e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
0a7c80e to
41233ee
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
reviewed
Jan 22, 2025
41233ee to
98b00cd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@hdwhdw The code has been updated to rename all gnoi_reboot to reboot, PTAL. |
|
Pls look at unit test results at sonic-net/sonic-buildimage#20713 (comment) |
hdwhdw
requested changes
Jan 30, 2025
11 tasks
|
@vvolam , could you please review |
|
@hdwhdw , could you please review |
98b00cd to
fd6e6de
Compare
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-host-services changes for cold reboot